tests: fix win32 #3172
tests: fix win32 #3172
Conversation
|
coverage failed because this: Lines 127 to 134 in fa6dac8
|
|
I just use pytest's tmp_path to create a real file on disk. pytest will clean it up after test. |
| @@ -122,6 +123,7 @@ def test_logging_redirect_chain(server, caplog): | |||
| ] | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.platform == "win32", reason="os path sep escaped on windows") | |||
There was a problem hiding this comment.
We don't need this skipif now, right?
There was a problem hiding this comment.
we still need this skipif because path seprator / is double escaped on this tests, don't know why....
There was a problem hiding this comment.
Can you remove the skipif, so we can see the exact error in CI?
There was a problem hiding this comment.
E
E At index 1 diff: ('httpx', 10, "load_verify_locations cafile='C:\\\\Users\\\\Trim21\\\\proj\\\\httpx\\\\.venv\\\\Lib\\\\site-packages\\\\certifi\\\\cacert.pem'") != ('httpx', 10, "load_verify_locations cafile='C:\\Users\\Trim21\\proj\\httpx\\.venv\\Lib\\site-packages\\certifi\\cacert.pem'")
E
E Full diff:
E [
E (
E 'httpx',
E 10,
E 'load_ssl_context verify=True cert=None trust_env=True http2=False',
E ),
E (
E 'httpx',
E 10,
E 'load_verify_locations '
E - "cafile='C:\\Users\\Trim21\\proj\\httpx\\.venv\\Lib\\site-packages\\certifi\\cacert.pem'",
E + "cafile='C:\\\\Users\\\\Trim21\\\\proj\\\\httpx\\\\.venv\\\\Lib\\\\site-packages\\\\certifi\\\\cacert.pem'",
E ? ++ ++ ++ ++ ++ ++ ++ ++ ++
E ),
E ]
| @pytest.mark.skipif( | ||
| sys.platform == "win32", reason="time related tests are flaky on win32" | ||
| ) |
There was a problem hiding this comment.
I assume we could drop this, and this particular test would actually pass okay on windows?
(Also, I think we might want to raise a related refactoring issue to remove these /slow_response tests completely.)
There was a problem hiding this comment.
this test may pass on windows.
There was a problem hiding this comment.
it's a time accuracy problem on windows. we could increase sleep time in /slow_response to several seconds to fix this.
There was a problem hiding this comment.
I'm wrong about this, looks like increase sleep time in /slow_response won't help testing write timeout
| @@ -32,3 +37,4 @@ jobs: | |||
| run: "scripts/test" | |||
| - name: "Enforce coverage" | |||
| run: "scripts/coverage" | |||
| if: "matrix.os == 'ubuntu'" | |||
There was a problem hiding this comment.
We probably don't need this conditional once we've fixed up all the tests to pass okay on windows, right?
|
|
||
| strategy: | ||
| matrix: | ||
| os: ["ubuntu", "windows"] |
There was a problem hiding this comment.
I'm not sure - I'm pleased to see us fix the test cases up for supporting windows, tho do we want to double the time our test runs take to complete?
Summary
There are several test cases broken on windows.
Checklist